-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create VideoPlayerStatsForNerds.vue #1403
create VideoPlayerStatsForNerds.vue #1403
Conversation
4fcbc6c
to
95d788c
Compare
95d788c
to
681124b
Compare
Docs can be based on info from https://www.w3.org/TR/webrtc-stats/#webidl-2021272228 |
Would be convenient to have some kind of info text from hovering over each field or a question mark or something, but that can be left for a later PR :-)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So cool!
One question: was the idea for the canvas to have a fixed size independent of the video widget size? I found it a little small on my screen (mac air 13in):
PS: thanks for putting the whole logic into another component. We are missing on doing that for other parts of the codebase and it really helps on maintenance.
having it small also allows us to use it on the secondary streams Screen.Recording.2024-10-11.at.23.10.19.1.movPS.: No, your dome is dirty, mine is great 🫠 |
Screen.Recording.2024-10-11.at.22.51.53.mov